Browse Source

Guard against empty headings when sorting

* org.el (org-sort-entries): Guard against empty headings when sorting
alphabetically, numerically.

Due to how ‘org-complex-heading-regexp’ is defined, the title capture group
currently returns nil in empty headings, which we don’t want to pass on to
‘org-sort-remove-invisible’.
Sebastian Reuße 7 years ago
parent
commit
1af7f303d5
1 changed files with 4 additions and 8 deletions
  1. 4 8
      lisp/org.el

+ 4 - 8
lisp/org.el

@@ -8734,15 +8734,11 @@ function is being called interactively."
 	  (lambda ()
 	    (cond
 	     ((= dcst ?n)
-	      (if (looking-at org-complex-heading-regexp)
-		  (string-to-number
-		   (org-sort-remove-invisible (match-string 4)))
-		nil))
+	      (string-to-number
+	       (org-sort-remove-invisible (org-get-heading t t t t))))
 	     ((= dcst ?a)
-	      (if (looking-at org-complex-heading-regexp)
-		  (funcall case-func
-			   (org-sort-remove-invisible (match-string 4)))
-		nil))
+	      (funcall case-func
+		       (org-sort-remove-invisible (org-get-heading t t t t))))
 	     ((= dcst ?k)
 	      (or (get-text-property (point) :org-clock-minutes) 0))
 	     ((= dcst ?t)