Browse Source

org-agenda-get-todos: Fix effort-up sorting in todo agenda

* lisp/org-agenda.el (org-agenda-get-todos): Calculate effort-minutes
before adding it as text property in agenda line.

Reported in https://old.reddit.com/r/emacs/comments/qfqcip/sorting_by_effort_doesnt_work_on_latest_org/
Ihor Radchenko 4 years ago
parent
commit
cf8906eee0
1 changed files with 1 additions and 1 deletions
  1. 1 1
      lisp/org-agenda.el

+ 1 - 1
lisp/org-agenda.el

@@ -5577,6 +5577,7 @@ and the timestamp type relevant for the sorting strategy in
 	      category (org-get-category)
               effort (save-match-data (or (get-text-property (point) 'effort)
                                           (org-entry-get (point) org-effort-property)))
+              effort-minutes (when effort (save-match-data (org-duration-to-minutes effort)))
 	      ts-date-pair (org-agenda-entry-get-agenda-timestamp (point))
 	      ts-date (car ts-date-pair)
 	      ts-date-type (cdr ts-date-pair)
@@ -5596,7 +5597,6 @@ and the timestamp type relevant for the sorting strategy in
                                   'effort-minutes effort-minutes)
                                 level category tags t)
 	      priority (1+ (org-get-priority txt)))
-        (setq effort-minutes (when effort (save-match-data (org-duration-to-minutes effort))))
 	(org-add-props txt props
 	  'org-marker marker 'org-hd-marker marker
 	  'priority priority